Fix .toTuple insertion #22028
Merged
Fix .toTuple insertion #22028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously did not follow aliases or upper bounds when deciding whether something was a named tuple.
There was a problem hiding this comment.
Should we replace all usages of isNamedTupleType with derivesFromNamedTuple?
There is Implicits#viewExists as a contender in particular.
|
I had a look at all occurrences of isNamedTuple and applied tweaks that looked reasonable. |
|
Do you think we should backport it to 3.6.2 or can it wait for 3.6.3? For me it looks like a candidate for RC3 backport |
EugeneFlesselle
approved these changes
Nov 26, 2024
|
I think it can wait. That way we have more time to see whether this causes
any issues. I don't expect them, but better to be sure.
…On Tue, Nov 26, 2024 at 5:13 PM Eugene Flesselle ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#22028 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGCKVRM6D4QBMT4VVTYQSL2CSM4DAVCNFSM6AAAAABSQIHMC6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRSGAZTCNZUHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Martin Odersky
Professor, Programming Methods Group (LAMP)
Faculty IC, EPFL
Station 14, Lausanne, Switzerland
|
This was referenced Nov 30, 2024
WojciechMazur
added a commit
that referenced
this pull request
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIP 58 postulates an implicit insertion ot
.toTuplewhen the target is a tuple and the source is a named tuple. This was previously not fully implemented. The implementation did not follow aliases or upper bounds when deciding whether something was a named tuple. This is fixed in this PR.